From 2735efaf7df2ad27fe97adb39a053a5de26a84ea Mon Sep 17 00:00:00 2001
From: huangzhen <867217663@qq.com>
Date: 星期四, 28 九月 2023 11:00:07 +0800
Subject: [PATCH] 代码优化

---
 exam-system/src/main/java/com/gkhy/exam/coalmine/service/impl/EduResourcesManagerServiceImpl.java |   14 ++++++--------
 1 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/exam-system/src/main/java/com/gkhy/exam/coalmine/service/impl/EduResourcesManagerServiceImpl.java b/exam-system/src/main/java/com/gkhy/exam/coalmine/service/impl/EduResourcesManagerServiceImpl.java
index 56459e9..98d0db3 100644
--- a/exam-system/src/main/java/com/gkhy/exam/coalmine/service/impl/EduResourcesManagerServiceImpl.java
+++ b/exam-system/src/main/java/com/gkhy/exam/coalmine/service/impl/EduResourcesManagerServiceImpl.java
@@ -1,5 +1,7 @@
 package com.gkhy.exam.coalmine.service.impl;
 
+import com.alibaba.fastjson2.JSON;
+import com.alibaba.fastjson2.TypeReference;
 import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
 import com.gkhy.exam.coalmine.entity.ExaminerManage;
 import com.gkhy.exam.coalmine.entity.ExaminerManageOperateTypeBind;
@@ -143,7 +145,7 @@
         ExaminerManage examinerByCode = examinerManageService.getExaminerByCode(reqDTO.getCode());
         if (examinerByCode != null && examinerByCode.getId() != reqDTO.getId())
             throw new BusinessException(this.getClass(),ResultConstants.SYSTEM_ERROR_DATABASE_FAIL,"身份证已存在");
-        ExaminerManage examinerManage = new ExaminerManage();
+        ExaminerManage examinerManage = examinerManageService.getExaminerById(reqDTO.getId());
         BeanUtils.copyProperties(reqDTO,examinerManage,"id");
         boolean save = examinerManageService.updateById(examinerManage);
         if (!save)
@@ -194,16 +196,14 @@
         if (CollectionUtils.isEmpty(list))
             return dto;
         Boolean flag = redisCache.hasKey(CacheConstants.SYS_OPERATE_TYPE_NAME_KEY);
-        Map<Long, SysOperateTypeWholeNameBO> map;
         if (flag){
             operateTypeService.resetOperateTypeCache();
         }
-        map  = redisCache.getCacheObject(CacheConstants.SYS_OPERATE_TYPE_NAME_KEY);
         List<GetExaminerOperateTypesRespDTO> getExaminerOperateTypesRespDTOS = new ArrayList<>();
         for (ExaminerManageOperateTypeBind examinerManageOperateTypeBind : list) {
             GetExaminerOperateTypesRespDTO operateTypesRespDTO = new GetExaminerOperateTypesRespDTO();
             BeanUtils.copyProperties(examinerManageOperateTypeBind,operateTypesRespDTO);
-            SysOperateTypeWholeNameBO sysOperateTypeWholeNameBO = map.get(examinerManageOperateTypeBind.getOperateTypeId());
+            SysOperateTypeWholeNameBO sysOperateTypeWholeNameBO = operateTypeService.getOperateTypeWholeNameById(examinerManageOperateTypeBind.getOperateTypeId());
             if (sysOperateTypeWholeNameBO != null){
                 BeanUtils.copyProperties(sysOperateTypeWholeNameBO,operateTypesRespDTO);
             }
@@ -265,7 +265,7 @@
         TeacherManage teacherByCode = teacherManageService.getTeacherByCode(reqDTO.getCode());
         if (teacherByCode != null && teacherByCode.getId() != reqDTO.getId())
             throw new BusinessException(this.getClass(),ResultConstants.SYSTEM_ERROR_DATABASE_FAIL,"身份证已存在");
-        TeacherManage teacherManage = new TeacherManage();
+        TeacherManage teacherManage = teacherManageService.getTeacherById(reqDTO.getId());
         BeanUtils.copyProperties(reqDTO,teacherManage,"id");
         boolean save = teacherManageService.updateById(teacherManage);
         if (!save)
@@ -321,16 +321,14 @@
         if (CollectionUtils.isEmpty(list))
             return dto;
         Boolean flag = redisCache.hasKey(CacheConstants.SYS_OPERATE_TYPE_NAME_KEY);
-        Map<Long, SysOperateTypeWholeNameBO> map;
         if (flag){
             operateTypeService.resetOperateTypeCache();
         }
-        map  = redisCache.getCacheObject(CacheConstants.SYS_OPERATE_TYPE_NAME_KEY);
         List<GetTeacherOperateTypesRespDTO> getTeacherOperateTypesRespDTOS = new ArrayList<>();
         for (TeacherManageOperateTypeBind examinerManageOperateTypeBind : list) {
             GetTeacherOperateTypesRespDTO operateTypesRespDTO = new GetTeacherOperateTypesRespDTO();
             BeanUtils.copyProperties(examinerManageOperateTypeBind,operateTypesRespDTO);
-            SysOperateTypeWholeNameBO sysOperateTypeWholeNameBO = map.get(examinerManageOperateTypeBind.getOperateTypeId());
+            SysOperateTypeWholeNameBO sysOperateTypeWholeNameBO = operateTypeService.getOperateTypeWholeNameById(examinerManageOperateTypeBind.getOperateTypeId());
             if (sysOperateTypeWholeNameBO != null){
                 BeanUtils.copyProperties(sysOperateTypeWholeNameBO,operateTypesRespDTO);
             }

--
Gitblit v1.9.2